[ 
https://issues.apache.org/jira/browse/TS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912411#comment-13912411
 ] 

ASF subversion and git services commented on TS-2586:
-----------------------------------------------------

Commit c00762c0f795a7bd6b979fec21bc93fda3ef3b51 in trafficserver's branch 
refs/heads/master from [~happy_fish100]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c00762c ]

TS-2586 Improvements to the internal implementation of overridable
configuration lookups (_conf_to_memberp() ).

Review: Leif


> the function _conf_to_memberp should be declared as static
> ----------------------------------------------------------
>
>                 Key: TS-2586
>                 URL: https://issues.apache.org/jira/browse/TS-2586
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Yu Qing
>            Assignee: Leif Hedstrom
>             Fix For: 5.0.0
>
>         Attachments: 
> 0001-TS-2586-change-the-prototype-of-_conf_to_memberp.patch
>
>
> in the file proxy/InkAPI.cc:
>  1. the function _conf_to_memberp should be declared as static
>  2. change the prototype of  function _conf_to_memberp for general purpose.
>   the old prototype as:
> void* _conf_to_memberp(TSOverridableConfigKey conf, HttpSM* sm, 
> OverridableDataType *typep)
>   the new prototype as:
> static void* _conf_to_memberp(TSOverridableConfigKey conf,
>     OverridableHttpConfigParams *overridableHttpConfig,
>     OverridableDataType *typep) 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to