[
https://issues.apache.org/jira/browse/TS-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913879#comment-13913879
]
ASF GitHub Bot commented on TS-2553:
------------------------------------
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/51
TS-2553 Fix a crash in the Metalink plugin
I think the existing CHANGES entry for this issue still covers it.
Please feel free to squash any of the changes to clean them up, and let me
know if I can improve the style.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver TS-2553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit ca66472b5a8f002dc6720e9e9721db51038c6e9d
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:00:30Z
metalink: If not at the end yet and can't read any more content then can't
compute the digest
commit 5e2d74dadfd9dcb00dd92f74137a5eaede05c8b9
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:06:53Z
metalink: Zero the downstream nbytes is a shortcut to get it to send a
TS_EVENT_VCONN_WRITE_COMPLETE event
commit 1982f72db5f56a3210febe48345cdea339f8c459
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:11:30Z
TS-2553 metalink: Avoid failed assert
"sdk_sanity_check_iocore_structure(connp) == TS_SUCCESS" in TSVConnWrite() if
the response is 304 Not Modified
commit c4e1f07180e17e48f591724945bb1c667d4efea3
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:13:57Z
metalink: Add some functional tests
commit f6cc83d770a8b168a63dfd627cfa6569c8342a84
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:22:36Z
metalink: Add Makefile target to run all the tests
commit 2d8483d9e40937daee0185decace3fcb44f97020
Author: Jack Bates <[email protected]>
Date: 2014-02-20T21:35:25Z
metalink: Declare variables outside switch statement, for consistency
----
> Fix a segfault in the Metalink plugin reported by Faysal Banna and preserve
> the Content-Length header
> -----------------------------------------------------------------------------------------------------
>
> Key: TS-2553
> URL: https://issues.apache.org/jira/browse/TS-2553
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Jack Bates
> Assignee: James Peach
> Fix For: 5.0.0
>
>
> Fix a segfault in the Metalink plugin reported by Faysal Banna:
> https://github.com/jablko/dedup/issues/1
> Copy the upstream nbytes (if known) downstream to preserve the Content-Length
> header.
> Improve comments in the plugin code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
