[
https://issues.apache.org/jira/browse/TS-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919142#comment-13919142
]
Leif Hedstrom commented on TS-2610:
-----------------------------------
Alright, I now see that the 0001 patch provides some special cases used for
these log tags. At a minimum, I feel these two commits should be on two
different Jira tickets, since they are different issues. One can be "linked" to
the other though.
I still feel that the log values ought to be tied to the ALPN negotiation
though, which perhaps also affects both of these patches ? I guess I have to
defer to [~jamespeach] here, he's the SSL guru.
> Add "client_req_proto_type", %<cqpt> field into LogFormat
> ---------------------------------------------------------
>
> Key: TS-2610
> URL: https://issues.apache.org/jira/browse/TS-2610
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging
> Reporter: Yunkai Zhang
> Assignee: Yunkai Zhang
> Fix For: 5.0.0
>
> Attachments:
> 0001-TS-2610-Indroduce-TSHttpConnectWithProtoType-API.patch,
> 0002-TS-2610-Add-client_req_proto_type-cqpt-field-into-Lo.patch
>
>
> This ticket was split from SPDY ticket(TS-2431).
> Add %<cqpt> field into LogFormat, so that we can distinguish the protocol
> type of each log record, it can help us to to do some analysis and statistic.
> Here are the available values of %<cqpt>:
> {code}
> "HTTP" -- HTTP protocol
> "HTTP_SSL" -- HTTP with SSL protocol
> "HTTP_SPDY" -- HTTP with SPDY protocol
> "HTTP_SPDY_SSL" -- HTTP with SPDY with SSL protocol
> {code}
> For some plugins that using TSHttpConnect() API to do request, the Logging
> module can't know which protocol type is used, so I add a new API:
> {code}
> tsapi TSVConn TSHttpConnectWithProtoType(struct sockaddr const* addr,
> TSNetProtoType proto_type);
> {code}
> After introducing TSHttpConnectWithProtoType() API, TSHttpConnect() API would
> be a special case of it:
> {code}
> TSVConn
> TSHttpConnect(sockaddr const* addr)
> {
> return TSHttpConnectWithProtoType(addr, TS_NET_PROTO_HTTP);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
