[ 
https://issues.apache.org/jira/browse/TS-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948084#comment-13948084
 ] 

ASF subversion and git services commented on TS-2663:
-----------------------------------------------------

Commit ab0844c8232070cf7063b38a94c51c5acce2ca24 in trafficserver's branch 
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ab0844c ]

Added TS-2663 to CHANGES>


> [HttpTransactHeaders.cc:622]: (style) Same expression on both sides of '||'.
> ----------------------------------------------------------------------------
>
>                 Key: TS-2663
>                 URL: https://issues.apache.org/jira/browse/TS-2663
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: David Binderman
>            Assignee: Leif Hedstrom
>             Fix For: 5.0.0
>
>
> Source code is
>     if (log_code == SQUID_LOG_TCP_MISS || log_code == SQUID_LOG_TCP_MISS) {
> Judging by code a few lines further down, maybe the following
> code was intended
>    if (log_code == SQUID_LOG_TCP_MISS || log_code == SQUID_LOG_TCP_IMS_MISS) {
> I found this possible problem by using cppcheck, a static analysis checker.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to