[
https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964589#comment-13964589
]
Faysal Banna commented on TS-2555:
----------------------------------
+1 on updating ts-lua. but some issues needs to be addressed before i believe.
ts-lua that portl4t notes uses Lua-5.1 while The last release was Lua 5.1.5,
released on 17 Feb 2012.
New systems mostly come with Lua-5.2 The current release is Lua 5.2.3, released
on 07 Dec 2013 and initial 5.2 release was 16 Dec 2011.
taking into consideration the compilation issues that arises between two
versions as i had while was compiling it on Fedora-20.
<code>
ts_lua_util.c: In function ‘ts_lua_create_vm’:
ts_lua_util.c:57:26: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_pushvalue(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c:57:26: note: each undeclared identifier is reported only once for
each function it appears in
ts_lua_util.c: In function ‘ts_lua_add_module’:
ts_lua_util.c:126:24: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(L, LUA_GLOBALSINDEX); /* L[GLOBAL] = TB1
*/
^
ts_lua_util.c: In function ‘ts_lua_del_module’:
ts_lua_util.c:213:24: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(L, LUA_GLOBALSINDEX); /* L[GLOBAL] =
L[REG][conf] */
^
ts_lua_util.c: In function ‘ts_lua_set_instance_conf’:
ts_lua_util.c:312:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_instance_conf’:
ts_lua_util.c:321:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_set_http_ctx’:
ts_lua_util.c:334:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_http_ctx’:
ts_lua_util.c:343:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_create_http_ctx’:
ts_lua_util.c:383:20: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(l, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_set_http_intercept_ctx’:
ts_lua_util.c:435:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_http_intercept_ctx’:
ts_lua_util.c:444:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
make: *** [ts_lua_util.lo] Error 1
</code>
while current ts-lua compiles without any errors with luajit enabled and
experimental-plugins enabled for both lua-5.1 and lua-5.2
also had to face an issue which i believe could be resolved easily once those
issues cleared off which is
<code>
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: Could not add rule at line
#195; Aborting!
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: [ReverseProxy] Can't load
plugin "/usr/local/libexec/trafficserver/libtslua.so" -
/usr/local/libexec/trafficserver/libtslua.so: undefined symbol: lua_tointegerx
at line 195
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: something failed during
BuildTable() -- check your remap plugins!
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: Can not load the remap
table, exiting out!
</code>
other than this i recommend the update as the features in portl4t's libtslua
plugin is great for the needs of modern dynamic cache system and eliminates the
need for any cacheurl or header_rewrite plugin and thus combine config files in
much one place easier to track and easier to maintain
Much Regards
> Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
> -----------------------------------------------------------------------
>
> Key: TS-2555
> URL: https://issues.apache.org/jira/browse/TS-2555
> Project: Traffic Server
> Issue Type: Task
> Components: Plugins
> Reporter: Kit Chan
> Assignee: Kit Chan
> Fix For: 5.0.0
>
>
> As suggested by Igor Galic in TS-2335, "to avoid namespace pollution, we
> could move move the old Lua plugin to plugins/deprecated, and name this one
> lua again from the start. From what I gather, the consensus on the mailing
> list was to replace the old plugin with this one.
> Given that the old plugin was experimental, and we've decided that all bets
> regarding compatibility and stability are off in experimental, I'm fairly
> certain we can just do that. I'd move it, for easy reference into
> plugins/deprecated, remove it from the build, and once the new plugin has
> absorbed all of its features, remove it all together."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
