[
https://issues.apache.org/jira/browse/TS-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974262#comment-13974262
]
Leif Hedstrom commented on TS-1125:
-----------------------------------
Couple of comments on the latest patch:
1. It seems the new configuration is an overridable configuration, but there is
no support for that in ts/ts.h, InkAPI.cc nor are there any regression tests.
If this is not intended to be overridable, it should be moved out of the
overridable struct IMO.
2. The new WKS string is added before existing WKS strings, I think? Didn't we
agree to append new WKS's to the end of the list? Otherwise, you also have to
bump the cache version (at least the minor version), and force it to re-read
the WKS on every object. It seems better to append the new WKS. At a minimum,
you'd have to bump the cache minor version, to avoid that same crash problem
(but my vote is to append to the WKSs).
3. The "raw" write on the socket seems, unorthodox. Is there no way here to use
the normal VIO APIs ?
Cheers,
-- Leif
> POST's with Expect: 100-continue are slowed by delayed 100 response.
> --------------------------------------------------------------------
>
> Key: TS-1125
> URL: https://issues.apache.org/jira/browse/TS-1125
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 3.0.2
> Environment: TS 3.0.2 going to Apache 2.2 web server
> Reporter: William Bardwell
> Assignee: Bryan Call
> Priority: Minor
> Labels: yahoo
> Fix For: 5.0.0
>
> Attachments: TS-1125.diff, ts1125.diff
>
>
> Sending a post like:
> POST / HTTP/1.1
> Host: www.example.com
> Content-Length: 10
> Expect: 100-continue
> directly to the web server immediately sends back:
> HTTP/1.1 100 Continue
> And then when the post data is sent, a status 200 response comes back.
> But when going through ATS the "HTTP/1.1 100 Continue" is not sent
> immediately, and instead is sent after the POST data has been received. This
> is legal, but it makes clients that are hoping for a 100 continue to wait a
> little while hoping to get that, ATS should forward that response through
> immediately.
> Note: I see curl using "Expect: 100-continue" with > 1024 bytes of post data,
> but web searching indicates that some Microsoft products also use it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
