[
https://issues.apache.org/jira/browse/TS-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992921#comment-13992921
]
Bryan Call commented on TS-2636:
--------------------------------
There were a lot of the same issues as with the earlier patch. Please read and
follow the coding style documentation. I fixed all the issues this time and
committed the patch.
1. The patch didn't apply to LogField.h, it was last modified on 11/19/2013, so
there shouldn't have been an issue
2. Indentation is 2 spaces not 4 spaces - there is a mix of indentation
3. Don't use tabs for indentation
4. Remove spaces at the end of lines
5. Function return types need to be on a separate line
6. No spaces before the parentheses in function calls
7. Don't put spaces in between the function name and parentheses in function
declarations
8. Don't put braces on a new line for conditionals
good:
{code}
if (foo) {
{code}
bad:
{code}
if (foo)
{
{code}
Coding Style:
https://cwiki.apache.org/confluence/display/TS/Coding+Style
> Enhance ATS custom logging to support WIPE_FIELD_VALUE filter action
> --------------------------------------------------------------------
>
> Key: TS-2636
> URL: https://issues.apache.org/jira/browse/TS-2636
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging
> Reporter: Sudheer Vinukonda
> Assignee: Yunkai Zhang
> Labels: Review, yahoo
> Fix For: 5.0.0
>
> Attachments: ts2636.diff
>
>
> Currently, ATS custom logging supports LogFilters with actions Accept,
> Reject. This feature request is to add a new filter action "WIPE". WIPE can
> be used in hiding sensitive parameters (e.g. userid, password) within the
> query part of a URL. Attached is a draft version of the patch. Kindly review
> and comment.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
