[
https://issues.apache.org/jira/browse/TS-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kang li updated TS-2789:
------------------------
Description:
There is a typo in HttpSessionManger
(ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) ==
ats_ip_port_cast(addr)))
The fix would be
- (ats_ip_addr_eq(&s->server_ip.sa, addr) &&
ats_ip_port_cast(addr) == ats_ip_port_cast(addr)))
+ (ats_ip_addr_eq(&s->server_ip.sa, addr) &&
ats_ip_port_cast(&s->server_ip.sa) == ats_ip_port_cast(addr)))
This typo skip the port check, so if requests to same origin server would use
one same session even though different port.
Which would cause ATS-5.0 reuse wrong session to origin.
was:
There is a typo in HttpSessionManger
(ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) ==
ats_ip_port_cast(addr)))
The fix would be
- (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) ==
ats_ip_port_cast(addr)))
+ (ats_ip_addr_eq(&s->server_ip.sa, addr) &&
ats_ip_port_cast(&s->server_ip.sa) == ats_ip_port_cast(addr)))
This typo skip the port check, so if requests to same origin server would use
one same session even though different port.
Which would cause ATS-5.0 reuse wrong session to origin.
> Typo in HttpSessionManger would cause ATS reuse wrong session to origin
> server.
> -------------------------------------------------------------------------------
>
> Key: TS-2789
> URL: https://issues.apache.org/jira/browse/TS-2789
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: kang li
>
> There is a typo in HttpSessionManger
> (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) ==
> ats_ip_port_cast(addr)))
> The fix would be
> - (ats_ip_addr_eq(&s->server_ip.sa, addr) &&
> ats_ip_port_cast(addr) == ats_ip_port_cast(addr)))
> + (ats_ip_addr_eq(&s->server_ip.sa, addr) &&
> ats_ip_port_cast(&s->server_ip.sa) == ats_ip_port_cast(addr)))
> This typo skip the port check, so if requests to same origin server would use
> one same session even though different port.
>
> Which would cause ATS-5.0 reuse wrong session to origin.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
