[
https://issues.apache.org/jira/browse/TS-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masakazu Kitajo updated TS-2794:
--------------------------------
Attachment: extend-tsxs.diff
New patch is better than the PR #80, but I think generating shared_ptr.h with
autoconf still have same issue. The generated shared_ptr.h contains A include
directive and A namespace which depend on provider/packager's environment. This
means that the header file forces users (plugin developers) to use the same
file and namespace which are available in a provider's environment. It's not so
convenient.
So we should not depend on autoconf which runs on provider's environment and
should check whether we can use standard shared_ptr or not in users'
environment.
My idea is that extend tsxs to check the user's environment like a configure
script. I attached a patch for this (not tested well).
> Build failure related to header requirements of atscppapi
> ---------------------------------------------------------
>
> Key: TS-2794
> URL: https://issues.apache.org/jira/browse/TS-2794
> Project: Traffic Server
> Issue Type: Bug
> Components: CPP API
> Reporter: Ryo Okubo
> Assignee: Brian Geffon
> Fix For: 5.0.0
>
> Attachments: extend-tsxs.diff, shared_ptr_h_in.patch
>
>
> When I built my plugin outside of trafficserver source tree, I found build
> failure related to header requirements of atscppapi as below logs.
> {noformat}
> # I set /usr/local/trafficserver/ as prefix.
> In file included from
> /usr/local/trafficserver/include/atscppapi/Transaction.h:30:
> /usr/local/trafficserver/include/atscppapi/shared_ptr.h:28:10: fatal error:
> 'ink_autoconf.h' file not found
> #include "ink_autoconf.h"
> ^
> 1 error generated.
> {noformat}
> The shared_ptr.h requires a variable defined on ink_autoconf.h but it doesn't
> exist in destination directory. so I've already posted Pull-Request on GitHub
> to fix it. please review, and show me better solution if you have.
> https://github.com/apache/trafficserver/pull/80
--
This message was sent by Atlassian JIRA
(v6.2#6252)
