[
https://issues.apache.org/jira/browse/TS-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055141#comment-14055141
]
Bryan Call commented on TS-2921:
--------------------------------
[[email protected]]
Isn't this going to leak a byte every time ats_strdup() is called:
{code}
- SimpleTokenizer key_tok((char *)(sslMultCertSettings.key ?
sslMultCertSettings.key : ""), SSL_CERT_SEPARATE_DELIM);
+ SimpleTokenizer key_tok((char *)(sslMultCertSettings.key ?
&(*sslMultCertSettings.key) : ats_strdup("")), SSL_CERT_SEPARATE_DELIM);
{code}
> Build failure is caused by mismatching types
> --------------------------------------------
>
> Key: TS-2921
> URL: https://issues.apache.org/jira/browse/TS-2921
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Ryo Okubo
> Assignee: James Peach
> Attachments: fix_sslutils.diff
>
>
> After modification of TS-2893 merged, build failure is occured as below log.
> {noformat}
> SSLUtils.cc: In function 'SSL_CTX* SSLInitServerContext(const
> SSLConfigParams*, const ssl_user_config&)':
> SSLUtils.cc:976: error: operands to ?: have different types 'const
> xptr<char>' and 'const char [1]'
> SSLUtils.cc:986: warning: too many arguments for format
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
