[ 
https://issues.apache.org/jira/browse/TS-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056543#comment-14056543
 ] 

Bryan Call commented on TS-2780:
--------------------------------

>From dev@
{code}
Good suggestion - will update and resubmit the patch.

Thank you,

Sudheer

On 7/8/14, 12:38 PM, "James Peach" <jpe...@apache.org> wrote:

A helper function would make this cleaner:

SpdyRequest *
SpdyClientSession::find_request(int streamid) {
map<int32_t, SpdyRequest*>::iterator iter =
this->req_map.find(streamid);
return iter == this->req_map.end() ? NULL : iter->second;
}
{code}

> Core dump in SpdyRequest::clear() in production testing of SPDY
> ---------------------------------------------------------------
>
>                 Key: TS-2780
>                 URL: https://issues.apache.org/jira/browse/TS-2780
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: SPDY
>            Reporter: Sudheer Vinukonda
>            Assignee: Bryan Call
>              Labels: spdy, yahoo
>             Fix For: 5.1.0
>
>         Attachments: TS-2780.diff, ts2780.diff
>
>
> Noticed the below core dump in SpdyRequest::clear() during production testing 
> on our proxy platform.
> {code}
> NOTE: Traffic Server received Sig 11: Segmentation fault
> /home/y/bin/traffic_server - STACK TRACE: 
> /lib64/libpthread.so.0(+0x3420a0f500)[0x2b47cff7d500]
> /home/y/bin/traffic_server(_ZN11SpdyRequest5clearEv+0x14)[0x5d06d4]
> /home/y/bin/traffic_server(_ZN6SpdySM5clearEv+0x34)[0x5d0b84]
> /home/y/bin/traffic_server[0x5d13d1]
> /home/y/bin/traffic_server(_ZN18UnixNetVConnection14readSignalDoneEiP10NetHandler+0x3d)[0x6efbcd]
> /home/y/bin/traffic_server(_ZN17SSLNetVConnection11net_read_ioEP10NetHandlerP7EThread+0xc76)[0x6df3e6]
> /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x6e6b12]
> /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x8f)[0x714aaf]
> /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x493)[0x715453]
> /home/y/bin/traffic_server[0x713e5a]
> /lib64/libpthread.so.0(+0x3420a07851)[0x2b47cff75851]
> /lib64/libc.so.6(clone+0x6d)[0x34202e894d]
> {code}
> gdb output shows that req may be a null pointer in SpdySM::clear()
> {code}
> (gdb) bt
> #0  SpdyRequest::clear (this=0x0) at SpdySM.cc:44
> #1  0x00000000005d0b84 in SpdySM::clear (this=0x2aefdc4b46a0) at SpdySM.cc:116
> #2  0x00000000005d13d1 in spdy_default_handler (contp=<value optimized out>, 
> event=TS_EVENT_VCONN_INACTIVITY_TIMEOUT, edata=<value optimized out>) at 
> SpdySM.cc:258
> #3  0x00000000006eeabb in handleEvent (event=<value optimized out>, 
> vc=0x2aefcc141ca0) at ../../iocore/eventsystem/I_Continuation.h:146
> #4  read_signal_and_update (event=<value optimized out>, vc=0x2aefcc141ca0) 
> at UnixNetVConnection.cc:216
> #5  0x00000000006f3cd4 in UnixNetVConnection::mainEvent (this=0x2aefcc141ca0, 
> event=<value optimized out>, e=<value optimized out>) at 
> UnixNetVConnection.cc:1152
> #6  0x00000000006e7d0e in handleEvent (this=0x1634af0, event=<value optimized 
> out>, e=0x136e850) at ../../iocore/eventsystem/I_Continuation.h:146
> #7  InactivityCop::check_inactivity (this=0x1634af0, event=<value optimized 
> out>, e=0x136e850) at UnixNet.cc:67
> #8  0x0000000000714aaf in handleEvent (this=0x2aef48f91010, e=0x136e850, 
> calling_code=2) at I_Continuation.h:146
> #9  EThread::process_event (this=0x2aef48f91010, e=0x136e850, calling_code=2) 
> at UnixEThread.cc:145
> #10 0x0000000000715623 in EThread::execute (this=0x2aef48f91010) at 
> UnixEThread.cc:224
> #11 0x0000000000713e5a in spawn_thread_internal (a=0x163d000) at Thread.cc:88
> #12 0x00002aed0a8a1851 in start_thread () from /lib64/libpthread.so.0
> #13 0x00000034202e894d in clone () from /lib64/libc.so.6
> (gdb) print this
> $1 = (SpdyRequest * const) 0x0
> (gdb) up
> #1  0x00000000005d0b84 in SpdySM::clear (this=0x2aefdc4b46a0) at SpdySM.cc:116
> 116   in SpdySM.cc
> (gdb) print req
> $2 = (SpdyRequest *) 0x0
> (gdb) print iter
> $3 = {first = 25, second = }
> (gdb) print req_map
> $4 = std::map with 3 elements = {
>   [1] = 0x2aefd81e5ae0,
>   [25] = 0x0,
>   [27] = 0x0
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to