[ 
https://issues.apache.org/jira/browse/TS-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112335#comment-14112335
 ] 

Leif Hedstrom commented on TS-3048:
-----------------------------------

Interesting. This entire regression test looks weird to me. Such as, 
TSPluginDirGet() returns the setting from proxy.config.plugin.plugin_dir. Then 
we compare the results from TSPluginDirGet() and TSInstallDirGet(), making an 
assumption they should be the same. Now, granted, our regression tests are only 
expected to work with 'default' configs, so perhaps that's ok. Certainly your 
changes seems reasonable.

> Removed hard coded directory in TSPluginDirGet Regresson Test
> -------------------------------------------------------------
>
>                 Key: TS-3048
>                 URL: https://issues.apache.org/jira/browse/TS-3048
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Steven Feltner
>            Assignee: Leif Hedstrom
>             Fix For: 5.2.0
>
>         Attachments: plugin-dir-regression.patch
>
>
> The regression test for TSPluginDirGet TestCase2 references a hard coded 
> directory from the default layout.
> The attached patch replaces that hard coded directory with 
> TS_BUILD_LIBEXECDIR.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to