[
https://issues.apache.org/jira/browse/TS-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123030#comment-14123030
]
ASF GitHub Bot commented on TS-3059:
------------------------------------
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/107#issuecomment-54638343
This patch looks fine. Since this is an API change, it needs to got through
API review before I can pull it. Once comment that I'll make in API review will
be to ask whether ``rolling_size_mb`` can be unsigned.
https://cwiki.apache.org/confluence/display/TS/API+Review+Process
> Logging API is missing a TSTextLogObjectRollingSizeMbSet()
> ----------------------------------------------------------
>
> Key: TS-3059
> URL: https://issues.apache.org/jira/browse/TS-3059
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging, TS API
> Reporter: Brian Rectanus
> Fix For: sometime
>
>
> These all exist, but seems to be missing the API to set rolling size:
> * Enabled: TSTextLogObjectRollingEnabledSet()
> * Interval: TSTextLogObjectRollingIntervalSecSet()
> * Hour: TSTextLogObjectRollingOffsetHrSet()
> It seems the rolling size can only be set globally in records.config
> (proxy.config.log.rolling_size_mb) and in the logs_xml.config (<RollingSizeMb
> = "size_in_MB"/>).
> Please add the missing TSTextLogObjectRollingSizeMbSet() API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
