[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190270#comment-14190270
]
Alan M. Carroll commented on TS-3156:
-------------------------------------
Some notes -
I think changing the bool operators to a method is reasonable. Normally that's
done to check for existence via a wrapper but in this case it's checking both
existence and state, so the false case is a bit ambiguous.
Let's nuke ink_scoped_mutex if we're going to clean up other things in this
area.
Style -
{code}
/**
* Auto lock class for ProxyMutex
*/
{code}
should be
{code}
/** Auto lock class for ProxyMutex.
*/
{code}
This will make Doxygen happier.
> Mutex[Try]Lock bool() operator change and unused API removal
> ------------------------------------------------------------
>
> Key: TS-3156
> URL: https://issues.apache.org/jira/browse/TS-3156
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Powell Molleti
> Assignee: James Peach
> Priority: Minor
> Labels: review
> Fix For: 5.2.0
>
> Attachments: MutexLock-ats.patch
>
>
> Removed unused constructor in MutexLock along with set_and_take() method, had
> to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
> default bool and ! operator from both MutexLock and MutexTryLock with
> is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
> base.
> Ran make test will be performing more system testing. Posted before for early
> comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
