[ 
https://issues.apache.org/jira/browse/TS-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205280#comment-14205280
 ] 

Susan Hinrichs commented on TS-3155:
------------------------------------

Looks like I should be able to extend test_mime() easily enough to exercise the 
new method.

In terms of strncasecmp() vs ptr_len_cascmp().  They seem to be functionally 
equivalent.  Since strncasecmp() is standard these days (which was not the case 
10 years ago), shouldn't we be migrating to the OS standard version of these 
kind of utility functions?

> Add a value test method to the MIMEField class
> ----------------------------------------------
>
>                 Key: TS-3155
>                 URL: https://issues.apache.org/jira/browse/TS-3155
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Susan Hinrichs
>            Assignee: Susan Hinrichs
>             Fix For: 5.2.0
>
>         Attachments: ts-3155.patch
>
>
> In some cases, you don't need to directly manipulate the strings of values in 
> a mime field.  But you do need to test if a mime field contains a value (e.g. 
> does the Connection field contain the value "close").
> Currently, you must call MIMEField::value_get, but that does a bunch of 
> copies and string allocation which is not needed in our case.  We propose 
> adding a MIMEField::value_get_index method which returns the index of the 
> value in the list if it is present and -1 otherwise.  Will still need to do 
> the string parsing, but do not need to do the copies and allocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to