[ 
https://issues.apache.org/jira/browse/TS-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234615#comment-14234615
 ] 

Alan M. Carroll edited comment on TS-1570 at 12/4/14 9:01 PM:
--------------------------------------------------------------

If you're going to range check the port, why not

{code}
if (port && (port.size() > 5 || ink_atoi(port.data(), port.size()) >= 65536))
   ret = PARSE_ERROR;
{code}


was (Author: amc):
If you're going to range check the port, why not

```
if (port && (port.size() > 5 || ink_atoi(port.data(), port.size()) >= 65536))
   ret = PARSE_ERROR;
```

> remap doesn't reject request whose Host has extra characters after port (like 
> "test.com:80xxx")
> -----------------------------------------------------------------------------------------------
>
>                 Key: TS-1570
>                 URL: https://issues.apache.org/jira/browse/TS-1570
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>    Affects Versions: 3.3.0
>            Reporter: Conan Wang
>            Assignee: Cynthia Gu
>            Priority: Minor
>             Fix For: 5.3.0
>
>         Attachments: patch.diff, patch.diff1, patch.diff2, patch.diff3, 
> ts-1570-amc.diff, ts-1570-cynthiagu.diff
>
>
> remap.config:    map http://test.com  http://1.1.1.1
> The request with Host: 'test.com:80xxx' or 'test.com:xxx' will get passed. 
> Such host is not filtered strictly. 
> Just report, didn't have big problem for me though.
> curl http://127.0.0.1:8080/ -H "Host: test.com:80xxx"
> or curl -x 127.0.0.1:8080 http://test.com:80xxx/ -v



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to