[
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257584#comment-14257584
]
ASF GitHub Bot commented on TS-2157:
------------------------------------
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/157
[TS-2157] Replace "addr" with appropriate "src_addr" and "dst_addr" in
ConnectionAttributes
Have made initial changes. No added functionality as of yet. Have tested
and performs the same as previous addr/port version in my tests. Wondering if
someone could give this a look/if we should extend api to allow for more
control over local_addr and remote_addr. There will also be some occasions
where local_addr remains unused do we want to set it in all cases? If so,
where? Feel free to let me know in code review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yahoo/trafficserver TS-2157
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit 0cb7abe01e445552cee8d16b2f16e16925ac92f8
Author: es <[email protected]>
Date: 2014-12-16T23:33:27Z
changes to ConnectionAttributes struct
commit dc155ffbcd00be9db8fe5525d63f11d6f43a2866
Author: es <[email protected]>
Date: 2014-12-22T20:06:18Z
rename members
commit 852c7ecf0e3a8af194bef5d032b0b3c13bd6758d
Author: es <[email protected]>
Date: 2014-12-23T18:17:39Z
Changes for TS-2157
commit e4885da878b47cd463c065cf75b6564811553c91
Author: es <[email protected]>
Date: 2014-12-23T18:37:07Z
fix non client ports
----
> Replace "addr" with appropriate "src_addr" and "dst_addr" in
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
> Key: TS-2157
> URL: https://issues.apache.org/jira/browse/TS-2157
> Project: Traffic Server
> Issue Type: New Feature
> Components: Network
> Reporter: Leif Hedstrom
> Assignee: Eric Schwartz
> Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint)
> for each connection. In addition, we ought to be able to remove the "port"
> member from ConnectionAttributes as well, and its convoluted and overloaded
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the
> port information as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
