[
https://issues.apache.org/jira/browse/TS-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357437#comment-14357437
]
ASF GitHub Bot commented on TS-3436:
------------------------------------
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/178
TS-3436: Add API milestones
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-3436
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit bd62e7006547e9fc174a764b2c219f774643a31a
Author: William Bardwell <[email protected]>
Date: 2015-03-11T02:00:11Z
TS-3331: negative responses cached even when headers indicate otherwise
Apply full caching rules to negative cached responses.
commit 66bdd406f92e61bd0fdc86afe308a7563093896f
Author: William Bardwell <[email protected]>
Date: 2015-03-11T03:12:49Z
TS-3342 Non-standard method in bad request can cause crash
commit c98c3c6b97f17e11af8180826fa954a2c4db45a1
Author: Alan M. Carroll <[email protected]>
Date: 2015-03-11T14:09:27Z
TS-3436: Add API milestones.
----
> Add milestone data for API times
> --------------------------------
>
> Key: TS-3436
> URL: https://issues.apache.org/jira/browse/TS-3436
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Alan M. Carroll
> Assignee: Alan M. Carroll
>
> Add two new milestones that track API time, "active" and "total". These are
> reasonably equivalent to "wall clock time" and "cpu time" concepts for
> process. The total time measures how long, in real time, a transaction spends
> involved with API callouts in plugins. The active time tracks the amount of
> time spent in an API callout. When these two values are different this means
> time is being spent either in lock contention to run the plugin continuation
> or waiting for the plugin to re-enable the transaction. Originally I had just
> the "total" counter but I think the ability to detect contention and wait is
> very valuable.
> The values are a bit odd - they are the actual amount of time spent plus the
> start time of the state machine. I debated for a while about that with some
> other contributors and the concenssus was that overall the best option
> because it makes those milestones behave exactly like all the others (e.g.,
> you subtract sm_start to get the real value).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
