[ 
https://issues.apache.org/jira/browse/TS-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372264#comment-14372264
 ] 

Leif Hedstrom commented on TS-3459:
-----------------------------------

Do we really need a new config for this? Why not overlap it on the existing 
one? Now we have

{code}
  {RECT_CONFIG, "proxy.config.http.send_100_continue_response", RECD_INT, "0", 
RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
  {RECT_CONFIG, "proxy.config.http.disallow_post_100_continue", RECD_INT, "0", 
RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
{code}

But why not have the first take multiple values? I don't feel strongly about 
this, but it's a pretty common pattern to have configurations be "levels", and 
not booleans. So, we could have

{code}
0 - Don't send 100 Cont
1 - Send 100 Cont
2  - Send 100 Cont as long as method is not POST
{code}


> Create a new config to disallow Post w/ Expect: 100-continue.
> -------------------------------------------------------------
>
>                 Key: TS-3459
>                 URL: https://issues.apache.org/jira/browse/TS-3459
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 5.3.0
>
>
> This is something that's been bothering us for a while, we want a way to 
> explicitly disallow Posts w/ Expect: 100-continue. I'm going to add a small 
> block of code (configurable of course) that will allow you to return a 405 
> Method Not Allowed if enabled. This config will default to OFF to maintain 
> backwards compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to