[
https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491917#comment-14491917
]
ASF GitHub Bot commented on TS-1774:
------------------------------------
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/185
TS-1774 Moved gethrtime functions into Thread class
Moved ink_get_hrtime() and ink_get_based_hrtime() into the Thread.cc class
as opposed to them being an extern function in P_Thread.h. Also made them
static functions. Fixed the rest of the code base to refer to new functions.
Running 'make test' seemed to work.
Please let me know if anything is wrong, I'd be happy to correct any
errors. Also please let me know if this change actually makes sense, because
with my limited knowledge this was the only solution I could come up with.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 817613a973a28e6aa281098881c56d5fe160257e
Author: Daniel Xu <[email protected]>
Date: 2015-04-13T04:39:51Z
TS-1774 Move gethrtime functions into Thread class
Tested: Debian Jessie Testing
Author: Daniel Xu <[email protected]>
Moved ink_get_hrtime() and ink_get_based_hrtime()
into the Thread.cc class and made them static
functions as well to support object free calling.
Also changed all references in code base to these
two functions to refer to Thread::ink_get_...
instead.
commit 4f08f9f760b211f51d64079aa433ea741a5128a7
Author: Daniel Xu <[email protected]>
Date: 2015-04-13T04:59:35Z
TS-1774 Move gethrtime functions into Thread class
Tested: Debian Jessie Testing
Author: Daniel Xu <[email protected]>
Moved ink_get_hrtime() and ink_get_based_hrtime()
into the Thread.cc class and made them static
functions as well to support object free calling.
Also changed all references in code base to these
two functions to refer to Thread::ink_get_...
instead. Also fixed my own tab spacing issue.
----
> Make ink_hrtime_get() in Thread.cc member of the Thread class
> -------------------------------------------------------------
>
> Key: TS-1774
> URL: https://issues.apache.org/jira/browse/TS-1774
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Leif Hedstrom
> Labels: newbie
> Fix For: 6.0.0
>
>
> It's somewhat confusing that e..g ink_get_hrtime() is not a member of the
> Thread class, yet, relies on Thread::cur_time. Why is that ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
