[ 
https://issues.apache.org/jira/browse/TS-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507399#comment-14507399
 ] 

James Peach commented on TS-3546:
---------------------------------

My understanding is that registration was always required. I don't think that 
optional registration makes sense; it should be compulsory or not at all.

I think that there are benefits to knowing what plugins are loaded in the core 
that we don't take advantage of. If we ever implement plugin reloading, then 
the registered plugin instance is the natural place to track the resources 
allocated by a plugin. There is a need to track what a plugin does, for example 
TSHttpConnectWithPluginId(), which could have been implemented to automatically 
chain back to the plugin registration if we associated continuations with 
plugins (which we could do relatively easily).

> Remove TSPluginRegister API or make the version checking work
> -------------------------------------------------------------
>
>                 Key: TS-3546
>                 URL: https://issues.apache.org/jira/browse/TS-3546
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>    Affects Versions: 5.3.0
>            Reporter: Bryan Call
>             Fix For: 6.0.0
>
>
> IRC discussion about it:
> {code}
> 09:29:39]  <@bcall>   why do we want plugins to register?
> [09:30:06]  <@jpeach> afaik historically it's always been a requirement
> [09:30:30]  <@bcall>  I don't think so
> [09:30:33]  <@jpeach> imho there should be a way for  plugin to fail at 
> startup
> [09:30:53]  <@jpeach> if register does nothing useful then we should just 
> remove it
> [09:31:46]  <@bcall>  it was used for API version checking from what I 
> remember
> [09:31:52]  <@jpeach> but registration creates internal info that could be 
> used for something interesting
> [09:31:54]  <@bcall>  and I never did it in my plugins
> [09:32:18]  <@sudheerv>       fwiw, i think i didn't either ;)
> [09:32:52]  <@jpeach> heh
> [09:32:54]  <@bcall>  it is helpful for 3rd party plugins - vender, email, etc
> [09:33:13]  <@bcall>  and api version checking
> [09:33:14]  <@jpeach> that information never goes anywhere
> [09:33:20]  <@bcall>  I can see the merit of the version checking
> [09:33:21]  <@jpeach> the version checking does nothing
> [09:33:28]  <@bcall>  even better :)
> [09:33:40]  <@jpeach> sounds like you should nuke it for 6.0
> [09:34:09]  <@bcall>  I will file a bug
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to