[
https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514935#comment-14514935
]
Leif Hedstrom edited comment on TS-1015 at 4/27/15 9:07 PM:
------------------------------------------------------------
[~jamespeach] Would you mind elaborate on this a bit? Is this really a big
concern? It's not like the APIs can do anything nasty with the knowledge of
internal events.
Having everything unified into one enum type has some major advantages. [~amc]
had some ideas around auto-generating two include files, one internal and one
external, from a formatted text file. That would address James' concerns, but
I'm personally on the fence if it's worth this sort of complexity vs just
having one enum in one well known place (apidefs.h).
was (Author: zwoop):
[~jamespeach] Would you mind elaborate on this a bit? Is this really a big
concern? It's not like the APIs can do anything nasty with the knowledge of
internal events.
Having everything unified into one enum type has some major advantages. [~amc]
had some ideas around auto-generating two include files, one internal and one
external, from a formatted text file. That would addressed your concerns, but
I'm personally on the fence if it's worth this sort of complexity.
> TSEvent is widely declared as int
> ---------------------------------
>
> Key: TS-1015
> URL: https://issues.apache.org/jira/browse/TS-1015
> Project: Traffic Server
> Issue Type: Bug
> Components: Cleanup
> Reporter: Nick Kew
> Assignee: Meera Mosale Nataraja
> Priority: Minor
> Labels: api-change, newbie
> Fix For: 6.0.0
>
> Attachments: TS-1015-2.diff, TS-1015.diff
>
>
> TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is
> declared as type int. This makes it harder to follow/debug using tools like
> *trace or gdb.
> This may usefully be fixed as and when people encounter instances of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
