[
https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561474#comment-14561474
]
Sudheer Vinukonda edited comment on TS-3642 at 5/27/15 6:52 PM:
----------------------------------------------------------------
This issue is a consequence of the commit
a020cb2943f78f77ba8c928001359e8a2440cd28 (Coverity CID #1196453).
The original implementation of the settings
*proxy.config.http.server_session_sharing.pool*,
*proxy.config.http.server_session_sharing.match* claims to maintain backward
compatibility with the existing setting
*proxy.config.http.share_server_sessions*, but, the order in which these
settings are being read is always the old setting first, followed by the new
settings, which means, the new settings would override the old setting always.
Both old and new settings have default values (defaulting to per-thread pool).
Changing the *proxy.config.http.share_server_sessions* doesn't help, since the
default values for the new settings always override it, due to the order in
reading. There's also a bug in the update call back function for the new
settings, where the pool setting is read into match and match into pool.
However, the original implementation had a bug in reading the new settings,
which made it behave in such a way that the old setting would take affect
always. This bug in reading the setting was fixed in commit
a020cb2943f78f77ba8c928001359e8a2440cd28, exposing the backward compatibility
issue.
was (Author: sudheerv):
This issue is a consequence of the commit
a020cb2943f78f77ba8c928001359e8a2440cd28 (Coverity CID #1196453).
The original implementation of the settings
*proxy.config.http.server_session_sharing.pool*,
*proxy.config.http.server_session_sharing.match* claims to maintain backward
compatibility with the existing setting
*proxy.config.http.share_server_sessions*, but, the order in which these
settings are being read is always the old setting first, followed by the new
settings. Both old and new settings have default values (defaulting to
per-thread pool), which means, the new settings would override the old setting
always.
However, the original implementation had a bug in reading the new settings,
which made it behave in such a way that the old setting would take affect
always. This bug in reading the setting was fixed in commit
a020cb2943f78f77ba8c928001359e8a2440cd28, exposing the backward compatibility
issue.
> proxy.config.http.share_server_sessions not working
> ---------------------------------------------------
>
> Key: TS-3642
> URL: https://issues.apache.org/jira/browse/TS-3642
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 5.3.0
> Reporter: David Carlin
> Assignee: Sudheer Vinukonda
>
> Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no
> longer works. Saw a 10-15x increase in origin connections; there appears to
> be some reuse, I am seeing approximately 1.2-1.3 requests per origin
> connection.
> Setting "proxy.config.http.server_session_sharing.pool = global" restored
> expected behavior (Thanks [~sudheerv]!)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
