[
https://issues.apache.org/jira/browse/TS-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584439#comment-14584439
]
Phil Sorber commented on TS-1985:
---------------------------------
[~cqian], Is this code still needed?
{noformat}
$ grep -r PreDefinedFormat
proxy/logging/LogPredefined.cc:PreDefinedFormatInfo *
proxy/logging/LogPredefined.cc: return new PreDefinedFormatInfo(fmt,
"error.log", NULL /* no log header */, LOG_FILE_ASCII, false);
proxy/logging/LogPredefined.cc:PreDefinedFormatList::PreDefinedFormatList()
proxy/logging/LogPredefined.cc:PreDefinedFormatList::~PreDefinedFormatList()
proxy/logging/LogPredefined.cc: PreDefinedFormatInfo *info;
proxy/logging/LogPredefined.cc:PreDefinedFormatList::init(LogConfig *config)
proxy/logging/LogPredefined.h:struct PreDefinedFormatInfo {
proxy/logging/LogPredefined.h: LINK(PreDefinedFormatInfo, link);
proxy/logging/LogPredefined.h: PreDefinedFormatInfo(LogFormat *fmt, const char
*fname, const char *hdr, LogFileFormat _f, bool _c)
proxy/logging/LogPredefined.h:typedef Queue<PreDefinedFormatInfo>
PreDefinedFormatInfoList;
proxy/logging/LogPredefined.h:struct PreDefinedFormatList {
proxy/logging/LogPredefined.h: PreDefinedFormatList();
proxy/logging/LogPredefined.h: ~PreDefinedFormatList();
proxy/logging/LogPredefined.h: PreDefinedFormatInfoList formats;
proxy/logging/LogPredefined.h:// Return a PreDefinedFormatInfo structure for
the ASCII error log.
proxy/logging/LogPredefined.h:PreDefinedFormatInfo
*MakePredefinedErrorLog(LogConfig *config);
proxy/logging/LogConfig.h:struct PreDefinedFormatList;
proxy/logging/LogConfig.h:struct PreDefinedFormatInfo;
proxy/logging/LogConfig.h: LogFilter *split_by_protocol(const
PreDefinedFormatList &pre_def_info_list);
proxy/logging/LogConfig.h: size_t split_by_hostname(const PreDefinedFormatList
&pre_def_info_list, LogFilter *reject_protocol);
proxy/logging/LogConfig.h: LogObject *create_predefined_object(const
PreDefinedFormatInfo *pdi, size_t nfilters, LogFilter **filters,
proxy/logging/LogConfig.h: void create_predefined_objects_with_filter(const
PreDefinedFormatList &pre_def_info_list, size_t nfilters, LogFilter **filters,
proxy/logging/LogConfig.cc: PreDefinedFormatInfo *info;
proxy/logging/LogConfig.cc:LogConfig::create_predefined_object(const
PreDefinedFormatInfo *pdi, size_t num_filters, LogFilter **filter, const char
*filt_name,
proxy/logging/LogConfig.cc:LogConfig::create_predefined_objects_with_filter(const
PreDefinedFormatList &predef, size_t nfilters, LogFilter **filters,
proxy/logging/LogConfig.cc: PreDefinedFormatInfo *pdi;
proxy/logging/LogConfig.cc:LogConfig::split_by_protocol(const
PreDefinedFormatList &predef)
proxy/logging/LogConfig.cc:LogConfig::split_by_hostname(const
PreDefinedFormatList &predef, LogFilter *reject_protocol_filter)
proxy/logging/LogConfig.cc: PreDefinedFormatList predef;
{noformat}
I came upon this during compilation:
{noformat}
LogPredefined.cc: In member function ‘void
PreDefinedFormatList::init(LogConfig*)’:
LogPredefined.cc:57:14: error: unused variable ‘fmt’ [-Werror=unused-variable]
LogFormat *fmt;
^
cc1plus: all warnings being treated as errors
{noformat}
> Eliminate built-in log formats in favor of logs_xml.config
> ----------------------------------------------------------
>
> Key: TS-1985
> URL: https://issues.apache.org/jira/browse/TS-1985
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Leif Hedstrom
> Assignee: Crystal Qian
> Labels: incompatible, newbie
> Fix For: 6.0.0
>
>
> I have a feeling that the hardcoded (built-in) log-formats was the old way of
> doing things, and logs_xml.config is the new way. As such, I'd like to
> propose that we eliminate all the built-in's, and provide all those formats
> in a default logs_xml.config.
> One thing that might be necessary to add is an option in the XML config to
> disable a log file. I don't know if that's easily doable without using XML
> comments, but would be easy to add and useful.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
