[ 
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598908#comment-14598908
 ] 

ASF GitHub Bot commented on TS-2157:
------------------------------------

Github user SolidWallOfCode commented on the pull request:

    https://github.com/apache/trafficserver/pull/182#issuecomment-114736912
  
    This looks basically OK but I think we might want to change `dst` and `src` 
to `local` and `remote`.  I think that's less ambiguous. I can do that as part 
of working on the pull request if it seems reasonable.


> Replace "addr" with appropriate "src_addr" and "dst_addr" in 
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
>                 Key: TS-2157
>                 URL: https://issues.apache.org/jira/browse/TS-2157
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Network
>            Reporter: Leif Hedstrom
>            Assignee: Eric Schwartz
>             Fix For: 6.1.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint) 
> for each connection. In addition, we ought to be able to remove the "port" 
> member from ConnectionAttributes as well, and its convoluted and overloaded 
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the 
> port information as necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to