[
https://issues.apache.org/jira/browse/TS-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604990#comment-14604990
]
ASF GitHub Bot commented on TS-3683:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/218#discussion_r33428565
--- Diff: doc/reference/api/TSNetVConnSSLCachedHitSet.en.rst ---
@@ -0,0 +1,32 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed
+ with this work for additional information regarding copyright
+ ownership. The ASF licenses this file to you under the Apache
+ License, Version 2.0 (the "License"); you may not use this file
+ except in compliance with the License. You may obtain a copy of
+ the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing
+ permissions and limitations under the License.
+
+
+TSNetVConnSSLCachedHitSet
+============
+
+Synopsis
+--------
+
+`#include <ts/ts.h>`
+
+.. c:function:: void TSNetVConnSSLCachedHitSet(TSVConn vc, int state)
+
+Description
+-----------
+
+ Mark an SSL Connection as reused, which means that an SSL Session Cache
or an SSL Ticket have been used to prevent a full handshake for this SSL
Connection.
+
--- End diff --
This API makes no sense to me. The core should know this and set the state
accordingly. The better API would be to enable the plugin to control ticket use
for an inbound connection but core should handle the ticket and tracking
whether it was used. This is the same reason the cqtr log tag makes sense
without any API to set that state.
> Add a tag to log SSL Session/Ticket HIT as well as TCP connection reused
> ------------------------------------------------------------------------
>
> Key: TS-3683
> URL: https://issues.apache.org/jira/browse/TS-3683
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: François Pesce
> Assignee: Alan M. Carroll
> Fix For: 6.1.0
>
>
> These tags would be useful for performance metrics collection:
> <%cqtr> The TCP reused status; indicates if this request went through an
> already established connection.
> <%cqssr> The SSL session/ticket reused status; indicates if this request hit
> the SSL session/ticket and avoided a full SSL handshake.
> both of them would display respectively 0 or 1 , if resp. not reused or
> reused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
