[ 
https://issues.apache.org/jira/browse/TS-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620477#comment-14620477
 ] 

ASF GitHub Bot commented on TS-3435:
------------------------------------

Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/243#issuecomment-119959897
  
    Looks good.  My only question is why you bothered to make this a dynamic 
config.  It seems like requiring a restart would not be bad.  
    
    I don't think there are any bad race conditions here.  And I suppose of the 
operator is honing in on a desirable collection interval the dynamic restart 
might be useful.


> Make Log.cc:PERIODIC_TASKS_INTERVAL configurable
> ------------------------------------------------
>
>                 Key: TS-3435
>                 URL: https://issues.apache.org/jira/browse/TS-3435
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Frank Chan
>            Priority: Minor
>              Labels: newbie
>             Fix For: sometime
>
>
> It seems proxy.config.log.max_secs_per_buffer doesn't work below 5 secs.
> Apparently, it is because Log.cc:PERIODIC_TASKS_INTERVAL is set to 5 secs.
> There are comments from the code that this may be configurable in future and 
> guess it may fix the issue.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to