[
https://issues.apache.org/jira/browse/TS-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625270#comment-14625270
]
ASF GitHub Bot commented on TS-1007:
------------------------------------
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/249
TS-1007: SSLN Close called before TXN Close
I'd appreciate a review on this. I feel pretty comfortable with the change
in HttpSM.cc to delay the session close until after the transaction has a
chance to close.
I also rearranged things in SpdyClientSession to better follow the
ProxyClientSession framework so the session start hook gets called and not just
the session close hook. I feel less sure about those changes, so I would
appreciate comments from the SPDY experts out there.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-1007
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit b4aea1685d39b03b03bcd95731c65bb7fe71bbc4
Author: shinrich <[email protected]>
Date: 2015-07-13T16:09:37Z
TS-1007: SSLN Close called before TXN Close
----
> SSN Close called before TXN Close
> ---------------------------------
>
> Key: TS-1007
> URL: https://issues.apache.org/jira/browse/TS-1007
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.1
> Reporter: Nick Kew
> Assignee: Susan Hinrichs
> Labels: incompatible
> Fix For: 6.0.0
>
>
> Where a plugin implements both SSN_CLOSE_HOOK and TXN_CLOSE_HOOK, the
> SSN_CLOSE_HOOK is called first of the two. This messes up normal cleanups!
> Details:
> Register a SSN_START event globally
> In the SSN START, add a TXN_START and a SSN_CLOSE
> In the TXN START, add a TXN_CLOSE
> Stepping through, I see the order of events actually called, for the simple
> case of a one-off HTTP request with no keepalive:
> SSN_START
> TXN_START
> SSN_END
> TXN_END
> Whoops, SSN_END cleaned up the SSN context, leaving dangling pointers in the
> TXN!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
