[ 
https://issues.apache.org/jira/browse/TS-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625856#comment-14625856
 ] 

Masaori Koshiba commented on TS-3766:
-------------------------------------

IMO, this is not related to TS-3675. TS-3675 looks like verifing parameters of 
SETTINGS frame.
This is verifing type of frames. Described in {{5.5.  Extending HTTP/2}} of RFC.

{quote}
Implementations MUST ignore unknown or unsupported values in all
extensible protocol elements.  Implementations MUST discard frames
that have unknown or unsupported types.  This means that any of these
extension points can be safely used by extensions without prior
arrangement or negotiation.  
{quote}

> Ignore unknown frame in debugging
> ---------------------------------
>
>                 Key: TS-3766
>                 URL: https://issues.apache.org/jira/browse/TS-3766
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Masaori Koshiba
>            Assignee: Leif Hedstrom
>             Fix For: 6.1.0
>
>         Attachments: ts-3766.patch
>
>
> When ATS with {{--enable-debug}} recieve a frame which has unknown frame type 
> in HTTP/2 stream, ATS aborts.
> ATS should just discard unknown frame.
> {noformat}
> FATAL: Http2ConnectionState.cc:643: failed assert `frame->header().type < 
> HTTP2_FRAME_TYPE_MAX`
> traffic_server: Aborted (Signal sent by tkill() 1 99)traffic_server - STACK 
> TRACE:
> /opt/ats/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xc3)[0x4fc831]
> /lib64/libpthread.so.0(+0xf710)[0x7f00d1762710]
> /lib64/libc.so.6(gsignal+0x35)[0x7f00cfe79625]
> /lib64/libc.so.6(abort+0x175)[0x7f00cfe7ae05]
> /opt/ats/lib/libtsutil.so.6(_Z12ink_fatal_vaPKcP13__va_list_tag+0x0)[0x7f00d253e839]
> /opt/ats/lib/libtsutil.so.6(_Z9ink_fatalPKcz+0x0)[0x7f00d253e8f0]
> /opt/ats/lib/libtsutil.so.6(_Z10ink_pfatalPKcz+0x0)[0x7f00d253e9b5]
> /opt/ats/lib/libtsutil.so.6(+0x3a54a)[0x7f00d253c54a]
> /opt/ats/bin/traffic_server(_ZN20Http2ConnectionState18main_event_handlerEiPv+0x2f2)[0x5d8a18]
> /opt/ats/bin/traffic_server(_ZN12Continuation11handleEventEiPv+0x6c)[0x4ffaae]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to