[
https://issues.apache.org/jira/browse/TS-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642036#comment-14642036
]
Alan M. Carroll commented on TS-3795:
-------------------------------------
This is caused by TS-3440. {{HttpTransact::handle_server_connection_not_open}}
assumes, in that assert, there was an error during the connection. Previously
the logic would set an {{EIO}} error if nothing else was set. The point of
TS-3440 is to prevent setting that error value, leading to this failed assert.
The purpose of not setting the value is it is to prevent marking the server as
down while also not retrying the server. The server shouldn't be marked down
because ATS did connect to it, but because we don't know how far the
transaction on the origin went the failure should be returned to the user agent
to deal with.
> Invalid assertion in handle_server_connection_not_open
> ------------------------------------------------------
>
> Key: TS-3795
> URL: https://issues.apache.org/jira/browse/TS-3795
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.1.0
> Reporter: Alan M. Carroll
> Priority: Minor
> Fix For: sometime
>
>
> In {{HttpTransact::handle_server_connection_not_open}} there is an early
> assert
> {code}
> ink_assert(s->current.server->had_connect_fail());
> {code}
> However, in {{HttpTransact::handle_response_from_server}} the cases of a
> parse error, connection closed, or a bad response all call this method and in
> none of these cases was there a connection failure. This causes an assertion
> which, to me, seems unreasonable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
