[ 
https://issues.apache.org/jira/browse/TS-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-2106:
------------------------------
    Fix Version/s:     (was: 6.1.0)
                   6.0.0

> Normalize TSError messages in plugins (and examples)
> ----------------------------------------------------
>
>                 Key: TS-2106
>                 URL: https://issues.apache.org/jira/browse/TS-2106
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Igor Galić
>            Assignee: Jun Jie Ng
>              Labels: newbie
>             Fix For: 6.0.0
>
>
> right now many of plugins send error messages without prefixing the plugin 
> they come from, this bad practice is also continued in our examples.
> many error messages also close with {{\n}}, although this is not necessary.
> We should fix this by "normalizing" the way we send those error messages.
> Our proposal is either:
> {code}
> TSError("%s: cannot parse file %s", PLUGIN_NAME, filename);
> {code}
> or:
> {code}
> TSError("[%s] cannot parse file %s", PLUGIN_NAME, filename);
> {code}
> I have no strong leanings towards either. BUT: We should have one consistent 
> format between examples and plugins and newly imported code. The word "error" 
> should not be repeated, as it is already in the "severity" ({{TSError()}}. 
> There should be *no* {{\n}} at the end of the message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to