[jira] [Created] (TS-3822) clang-analyzer: Value stored to 'stream' during its initialization is never read

[Leif Hedstrom (JIRA)]

Leif Hedstrom created TS-3822:
---------------------------------

             Summary: clang-analyzer: Value stored to 'stream' during its 
initialization is never read
                 Key: TS-3822
                 URL: https://issues.apache.org/jira/browse/TS-3822
             Project: Traffic Server
          Issue Type: Bug
          Components: HTTP/2
            Reporter: Leif Hedstrom


  Http2Stream *stream = cstate.find_stream(id);

Value stored to 'stream' during its initialization is never read

Assuming the code is correct, I suggest the following patch:

{code}
diff --git a/proxy/http2/Http2ConnectionState.cc 
b/proxy/http2/Http2ConnectionState.cc
index 4244468..3d94dfd 100644
--- a/proxy/http2/Http2ConnectionState.cc
+++ b/proxy/http2/Http2ConnectionState.cc
@@ -173,13 +173,13 @@ rcv_headers_frame(Http2ClientSession &cs, 
Http2ConnectionState &cstate, const Ht
     return Http2Error(HTTP2_ERROR_CLASS_CONNECTION, 
HTTP2_ERROR_PROTOCOL_ERROR);
   }
 
-  Http2Stream *stream = cstate.find_stream(id);
   if (id <= cstate.get_latest_stream_id()) {
     return Http2Error(HTTP2_ERROR_CLASS_STREAM, HTTP2_ERROR_STREAM_CLOSED);
   }
 
   // Create new stream
-  stream = cstate.create_stream(id);
+  Http2Stream *stream = cstate.create_stream(id);
+
   if (!stream) {
     return Http2Error(HTTP2_ERROR_CLASS_CONNECTION, 
HTTP2_ERROR_PROTOCOL_ERROR);
   }
{code}

[~masaori],  [~rokubo] or [~maskit] Does that seem reasonable?




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)