[
https://issues.apache.org/jira/browse/TS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682176#comment-14682176
]
ASF GitHub Bot commented on TS-306:
-----------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776865
--- Diff: proxy/logging/LogFile.h ---
@@ -168,8 +85,6 @@ class LogFile : public LogBufferSink, public RefCountObj
static int write_ascii_logbuffer(LogBufferHeader *buffer_header, int fd,
const char *path, const char *alt_format = NULL);
int write_ascii_logbuffer3(LogBufferHeader *buffer_header, const char
*alt_format = NULL);
- static bool rolled_logfile(char *file);
- static bool exists(const char *pathname);
--- End diff --
Is it worth taking these out? For client convenience it you could leave
them in and have them just forward to the `BaseLogFile` methods. Otherwise
you're forcing clients to be aware of the implementation details of `LogFile`
(e.g. that it uses `BaseLogFile`).
> enable log rotation for diags.log
> ---------------------------------
>
> Key: TS-306
> URL: https://issues.apache.org/jira/browse/TS-306
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Miles Libbey
> Assignee: Daniel Xu
> Labels: newbie
> Fix For: 6.1.0
>
>
> (from yahoo bug 913896)
> Original description
> by Leif Hedstrom 3 years ago at 2006-12-04 12:42
> There might be reasons why this file might get filled up, e.g. libraries used
> by plugins producing output on STDOUT/STDERR. A few suggestions have been
> made, to somehow rotate traffic.out. One possible solution (suggested by
> Ryan) is to use cronolog (http://cronolog.org/), which seems like a fine idea.
>
>
> Comment 1
> by Joseph Rothrock 2 years ago at 2007-10-17 09:13:24
> Maybe consider rolling diags.log as well. -Feature enhancement.
>
> Comment 2
> by Kevin Dalley 13 months ago at 2009-03-04 15:32:18
> When traffic.out gets filled up, error.log stops filing up, even though
> rotation is turned on. This is
> counter-intuitive. Rotation does not control traffic.out, but a large
> traffic.out will stop error.log from being
> written.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
