[ 
https://issues.apache.org/jira/browse/TS-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682192#comment-14682192
 ] 

Susan Hinrichs commented on TS-3777:
------------------------------------

I agree that draining things out in the error case is problematic particularly 
for posts, but I don't think that is the case here.  In tunnel_handler_ua, the 
half_close flag is only set when the event is WRITE_COMPLETE.  In the error 
cases it does not trigger.  The specific relevant code is below.

{code}
    // If the client could be pipelining or is doing a POST, we need to
    //   set the ua_session into half close mode

    // only external POSTs should be subject to this logic; ruling out internal 
POSTs here
    bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
    if (is_eligible_post_request) {
      NetVConnection *vc = ua_session->get_netvc();
      if (vc) {
        is_eligible_post_request = vc->get_is_internal_request() ? false : true;
      }
    }
    if ((is_eligible_post_request || t_state.client_info.pipeline_possible == 
true) && c->producer->vc_type != HT_STATIC &&
        event == VC_EVENT_WRITE_COMPLETE) {
      ua_session->set_half_close_flag();
    }
{code}


> TSHttpConnect and POST request does not fire TS_VCONN_READ_COMPLETE nor 
> TS_VCONN_EOS
> ------------------------------------------------------------------------------------
>
>                 Key: TS-3777
>                 URL: https://issues.apache.org/jira/browse/TS-3777
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: Daniel Vitor Morilha
>            Assignee: Susan Hinrichs
>              Labels: yahoo
>             Fix For: 6.1.0
>
>
> When using TSHttpConnect to connect to ATS itself (internal vconnection), 
> sending a POST request and receiving a CHUNKED response. ATS does not fire 
> neither TS_VCONN_READ_COMPLETE nor TS_VCONN_EOS.
> Trying to close the vconnection from the plug-in after receiving the last 
> chunk ("\r\n0\r\n") results into the PluginVC repeating the following message:
> {noformat}
> [Jul 14 21:24:06.094] Server {0x7ffff7fbe800} DEBUG: (pvc_event) [0] Passive: 
> Received event 1
> {noformat}
> I am glad to provide an example if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to