[
https://issues.apache.org/jira/browse/TS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692397#comment-14692397
]
ASF GitHub Bot commented on TS-306:
-----------------------------------
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36807553
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
{
- diags = new Diags(NULL, NULL, stdout);
+ BaseLogFile *blf = new BaseLogFile("stdout");
+ diags = new Diags(NULL, NULL, blf);
--- End diff --
If the third parameter is changed into `const char *`, there will exist
constructor ambiguities when, for example, `NULL` is the third parameter. I'm
probably missing something here, but I think any changes (that I can currently
think of) made to the API to disambiguate the parameters would decrease the
overall understandability of the API.
> enable log rotation for diags.log
> ---------------------------------
>
> Key: TS-306
> URL: https://issues.apache.org/jira/browse/TS-306
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Miles Libbey
> Assignee: Daniel Xu
> Labels: newbie
> Fix For: 6.1.0
>
>
> (from yahoo bug 913896)
> Original description
> by Leif Hedstrom 3 years ago at 2006-12-04 12:42
> There might be reasons why this file might get filled up, e.g. libraries used
> by plugins producing output on STDOUT/STDERR. A few suggestions have been
> made, to somehow rotate traffic.out. One possible solution (suggested by
> Ryan) is to use cronolog (http://cronolog.org/), which seems like a fine idea.
>
>
> Comment 1
> by Joseph Rothrock 2 years ago at 2007-10-17 09:13:24
> Maybe consider rolling diags.log as well. -Feature enhancement.
>
> Comment 2
> by Kevin Dalley 13 months ago at 2009-03-04 15:32:18
> When traffic.out gets filled up, error.log stops filing up, even though
> rotation is turned on. This is
> counter-intuitive. Rotation does not control traffic.out, but a large
> traffic.out will stop error.log from being
> written.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
