[
https://issues.apache.org/jira/browse/TS-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704998#comment-14704998
]
Sudheer Vinukonda edited comment on TS-2940 at 8/20/15 2:24 PM:
----------------------------------------------------------------
Sorry, my bad - it wasn't the exact same log (which you correctly point is a
NOTE that doesn't default to syslogs) mentioned in TS-3133. It was actually an
ERROR message (below) that was filling up syslogs (thanks to [~dcarlin] for
clarifying).
****{0x2aeac59d2700} ERROR: Failed to convert LogBuffer to ascii, have dropped
(552) bytes ****.
Fwiw, the log mentioned in TS-3133 was just an example though - I was thinking
about a mechanism to print 1/n messages into diags.log for any thing that gets
in there (which will include all the errors too), since, it wasn't being
rotated at the time. I definitely agree with you though - even if we did
support log rotation, printing an Error message every transaction is not
particularly useful. Such traces should just be converted to Note/Warning like
you suggest.
was (Author: sudheerv):
Sorry, my bad - it wasn't the exact same log (which you correctly point is a
NOTE that doesn't default to syslogs) mentioned in TS-3133. It was actually an
ERROR message (below) that was filling up syslogs (thanks to [~dcarlin] for
clarifying).
* {0x2aeac59d2700} ERROR: Failed to convert LogBuffer to ascii, have dropped
(552) bytes *.
Fwiw, the log mentioned in TS-3133 was just an example though - I was thinking
about a mechanism to print 1/n messages into diags.log for any thing that gets
in there (which will include all the errors too), since, it wasn't being
rotated at the time. I definitely agree with you though - even if we did
support log rotation, printing an Error message every transaction is not
particularly useful. Such traces should just be converted to Note/Warning like
you suggest.
> the Fatal() macro always crashes
> --------------------------------
>
> Key: TS-2940
> URL: https://issues.apache.org/jira/browse/TS-2940
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging
> Reporter: James Peach
> Assignee: James Peach
> Labels: yahoo
> Fix For: 5.1.0
>
>
> {{Diags::error_va}} uses the argument list twice, causing a crash in printf,
> father than logging a fatal error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
