[
https://issues.apache.org/jira/browse/TS-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740507#comment-14740507
]
ASF GitHub Bot commented on TS-3834:
------------------------------------
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/291
[TS-3834] Close connection after sending GOAWAY Frame
Fix [TS-3834](https://issues.apache.org/jira/browse/TS-3834)
```
$ ./h2spec -h `hostname` -p 4443 -t -k -s 5.4.1
5.4. Error Handling
5.4.1. Connection Error Handling
_ Receives a GOAWAY frame
68 tests, 1 passed, 67 skipped, 0 failed
All tests passed
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver ts-3834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit 9199dd4b6f7a22337d7b572907a3186ef36f08d8
Author: Masaori Koshiba <[email protected]>
Date: 2015-09-11T08:52:10Z
[TS-3834] Close connection after sending GOAWAY Frame
----
> Close a client session after sending GOAWAY with errors
> -------------------------------------------------------
>
> Key: TS-3834
> URL: https://issues.apache.org/jira/browse/TS-3834
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Ryo Okubo
> Assignee: Ryo Okubo
> Fix For: 6.1.0
>
>
> According to [Section 5.4.1 of
> RFC7540|https://tools.ietf.org/html/rfc7540#section-5.4.1] , after sending
> with error codes, a server must close TCP connection. Current ATS only sends
> GOAWAY but doesn't close client session.
> This behavior can be checked by [h2spec|https://github.com/summerwind/h2spec]
> with -s 5.4.1 option.
> {noformat}
> $ ./h2spec -h <host> -p <port> -s 5.4.1
> 5.4. Error Handling
> 5.4.1. Connection Error Handling
> × Receives a GOAWAY frame
> - After sending the GOAWAY frame, the endpoint MUST close the TCP
> connection.
> Expected: Connection close
> Actual: Error: Connection closed, but did not receive a GOAWAY
> Frame.
> 68 tests, 0 passed, 67 skipped, 1 failed
> ===============================================================================
> Failed tests
> ===============================================================================
> 5.4. Error Handling
> 5.4.1. Connection Error Handling
> × Receives a GOAWAY frame
> - After sending the GOAWAY frame, the endpoint MUST close the TCP
> connection.
> Expected: Connection close
> Actual: Error: Connection closed, but did not receive a GOAWAY
> Frame.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
