[ 
https://issues.apache.org/jira/browse/TS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743425#comment-14743425
 ] 

Masaori Koshiba edited comment on TS-3902 at 9/14/15 12:30 PM:
---------------------------------------------------------------

Fixes for this issue breaks 2 tests of h2spec.

ATS : 00b697d899f3fd87d6d891fd46dda804d4680c70
h2spec : v1.1.1

{code}
68 tests, 65 passed, 1 skipped, 2 failed

===============================================================================
Failed tests
===============================================================================

  6.2. HEADERS
    _ Sends a HEADERS frame followed by any frame other than CONTINUATION
      - The endpoint MUST treat the receipt of any other type of frame as a 
connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: RST_STREAM frame (Length: 4, Flags: 0, ErrorCode: 
STREAM_CLOSED)

  6.10. CONTINUATION
    _ Sends a CONTINUATION frame followed by any frame other than CONTINUATION
      - The endpoint MUST treat as a connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: RST_STREAM frame (Length: 4, Flags: 0, ErrorCode: 
STREAM_CLOSED)
{code}

All tests of h2spec-v1.1.1 are passed with my patch ([#292 on 
github|https://github.com/apache/trafficserver/pull/292]).


was (Author: masaori):
Fixes for this issue breaks 2 tests of h2spec.

ATS : 00b697d899f3fd87d6d891fd46dda804d4680c70
h2spec : v1.1.1

{code}
68 tests, 65 passed, 1 skipped, 2 failed

===============================================================================
Failed tests
===============================================================================

  6.2. HEADERS
    _ Sends a HEADERS frame followed by any frame other than CONTINUATION
      - The endpoint MUST treat the receipt of any other type of frame as a 
connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: RST_STREAM frame (Length: 4, Flags: 0, ErrorCode: 
STREAM_CLOSED)

  6.10. CONTINUATION
    _ Sends a CONTINUATION frame followed by any frame other than CONTINUATION
      - The endpoint MUST treat as a connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: RST_STREAM frame (Length: 4, Flags: 0, ErrorCode: 
STREAM_CLOSED)
{code}

All tests of h2spec-v1.1.1 are passed with my patch.

> Wrong conditional for checking on continuation frame and to send the go_away 
> frame
> ----------------------------------------------------------------------------------
>
>                 Key: TS-3902
>                 URL: https://issues.apache.org/jira/browse/TS-3902
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Bryan Call
>            Assignee: Bryan Call
>             Fix For: 6.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to