[
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804909#comment-14804909
]
ASF GitHub Bot commented on TS-3921:
------------------------------------
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141333600
This looks reasonable. Could you add a unit test for
```http2_are_frame_flags_valid()```, which should be straightforward now the
masks are correct.
I see that ```http2_frame_header_is_valid()``` does't raise an error on
invalid flags. Should we restore the check?
> HTTP/2 send protocol error on invalid data frame
> ------------------------------------------------
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Bryan Call
> Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2 0x000000000063fe61 in Http2ClientSession::main_event_handler
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at
> Http2ClientSession.cc:222
> 222 in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
