[
https://issues.apache.org/jira/browse/TS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965741#comment-14965741
]
Peter Chou commented on TS-3932:
--------------------------------
Hi. I confirmed that this behavior is not present in 5.3.0, but it is present
in later releases starting with 5.3.1. I traced the relevant code change to
iocore/net/UnixNetProcessor.cc:455 where THREAD_ALLOC in 5.3.0 was changed to
THREAD_ALLOC_INIT in 5.3.1. However, I think that the actual root problem also
exists in 5.3.0, but it was just being masked by this difference in the thread
allocation call.
I believe the root problem is in iocore/net/UnixConnection.cc:303
(Connection::open()) where the apply_options() call to set the TOS bits are
made before addr is assigned a valid value in Connection::connect() later on.
The addr must be valid in order for the addr.isIp4() check used in
apply_options() to work. Under 5.3.1, addr is uninitialized on all passes
through Connection::open while in 5.3.0 it is uninitialized for the first pass
but perhaps contains remnant values on subsequent passes.
Questions:
1. Thoughts on moving apply_options() from Connection::open to
Connection::connect (after the addr is set by setRemote(target))?
2. We are looking for a fix in the 5.3.x branch so should I open a separate
issue?
> TCP TOS not working
> -------------------
>
> Key: TS-3932
> URL: https://issues.apache.org/jira/browse/TS-3932
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Affects Versions: 6.0.0
> Reporter: Bryan Call
> Labels: Regression
> Fix For: 6.1.0
>
>
> jasonstrongman2016:
> In 5.3.0 the below works. However, seems to be broken in other
> releases. Including this one.
> # /opt/trafficserver60rc3/bin/traffic_ctl -V
> Apache Traffic Server - traffic_ctl - 6.0.0 - (build # 091616 on Sep
> 16 2015 at 16:49:13)
> # /opt/trafficserver60rc3/bin/traffic_ctl config match sock_packet_tos_out
> proxy.config.net.sock_packet_tos_out: 184
> #tcpdump
> 17:55:07.377780 IP (tos 0x0, ttl 64, id 45468, offset 0, flags [DF],
> proto TCP (6), length 60)
> 10.0.0.71.51306 > 74.125.227.196.80: Flags [S],
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
