[
https://issues.apache.org/jira/browse/TS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022917#comment-15022917
]
ASF GitHub Bot commented on TS-4038:
------------------------------------
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/347
TS-4038: Redundant `isdigit(b)` in `LogFormat::parse_escape_string
Simple fix that shouldn't have any side effects since isdigit is not
changing the value of b.
@bgaff
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/canselcik/trafficserver ts4038
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #347
----
commit 6d05033d7619eb668a84ed27803758666612ce67
Author: Can Selcik <[email protected]>
Date: 2015-11-23T20:05:20Z
TS-4038: Redundant `isdigit(b)` in `LogFormat::parse_escape_string(const
char*, int)`
Simple fix that shouldn't have any side effects since isdigit is not
changing the value of b.
----
> Redundant `isdigit(b)` in `LogFormat::parse_escape_string(const char*, int)`
> ----------------------------------------------------------------------------
>
> Key: TS-4038
> URL: https://issues.apache.org/jira/browse/TS-4038
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Can Selcik
>
> This seems to originally be a typo where isdigit is called twice on b within
> the same if conditional.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
