[
https://issues.apache.org/jira/browse/TS-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032299#comment-15032299
]
ASF GitHub Bot commented on TS-4043:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/356#discussion_r46189499
--- Diff: proxy/hdrs/HTTP.cc ---
@@ -161,6 +161,14 @@ is_digit(char c)
return ((c <= '9') && (c >= '0'));
}
+// test to see if a character is a valid character for a host in a URI
according to
+// RFC 2396
+inline static int
+is_host_char(char c)
+{
+ return (ParseRules::is_alpha(c) || ParseRules::is_digit(c) || (c ==
'-') || (c == '.'));
--- End diff --
What about colons for IPv6 addresses?
> Prevent bogus FQDN characters in host header
> --------------------------------------------
>
> Key: TS-4043
> URL: https://issues.apache.org/jira/browse/TS-4043
> Project: Traffic Server
> Issue Type: Bug
> Components: Security
> Reporter: Daniel Xu
> Assignee: Leif Hedstrom
> Fix For: 6.1.0
>
>
> Currently ATS isn't checking if a character is valid before letting it in as
> a hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
