Daniel Xu created TS-4054:
-----------------------------

             Summary: Incorrect ink_assert behavior in Diags.cc
                 Key: TS-4054
                 URL: https://issues.apache.org/jira/browse/TS-4054
             Project: Traffic Server
          Issue Type: Bug
          Components: Logging
            Reporter: Daniel Xu


In `lib/ts/Diags.cc:setup_diagslog()`, the statement `ink_assert(diags_log == 
NULL)` is incorrect. It should instead be: `if (blf == NULL) return`

We should not use an assert here either because when the function is passed a 
NULL `blf`, it means that some test doesn't want to use the diags.log log file 
and we should just not set up diagslog.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to