[ 
https://issues.apache.org/jira/browse/TS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kit Chan updated TS-4083:
-------------------------
    Description: 
{code}
** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()


________________________________________________________________________________________________________
*** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
331
332       GET_HTTP_CONTEXT(http_ctx, L);
333
334       url = luaL_checklstring(L, 1, &url_len);
335
336       if (url && url_len) {
>>>     CID 1343347:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "TSCacheUrlSet" without checking return value (as is done 
>>> elsewhere 4 out of 5 times).
337         TSCacheUrlSet(http_ctx->txnp, url, url_len);
338       }
339
340       return 0;
341     }
342
{code}

  was:

** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()


________________________________________________________________________________________________________
*** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
331
332       GET_HTTP_CONTEXT(http_ctx, L);
333
334       url = luaL_checklstring(L, 1, &url_len);
335
336       if (url && url_len) {
>>>     CID 1343347:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "TSCacheUrlSet" without checking return value (as is done 
>>> elsewhere 4 out of 5 times).
337         TSCacheUrlSet(http_ctx->txnp, url, url_len);
338       }
339
340       return 0;
341     }
342


> CID 1343347:  Error handling issues in ts_lua_http.c
> ----------------------------------------------------
>
>                 Key: TS-4083
>                 URL: https://issues.apache.org/jira/browse/TS-4083
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Lua, Plugins
>            Reporter: Kit Chan
>             Fix For: 6.2.0
>
>
> {code}
> ** CID 1343347:  Error handling issues  (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> ________________________________________________________________________________________________________
> *** CID 1343347:  Error handling issues  (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> 331
> 332       GET_HTTP_CONTEXT(http_ctx, L);
> 333
> 334       url = luaL_checklstring(L, 1, &url_len);
> 335
> 336       if (url && url_len) {
> >>>     CID 1343347:  Error handling issues  (CHECKED_RETURN)
> >>>     Calling "TSCacheUrlSet" without checking return value (as is done 
> >>> elsewhere 4 out of 5 times).
> 337         TSCacheUrlSet(http_ctx->txnp, url, url_len);
> 338       }
> 339
> 340       return 0;
> 341     }
> 342
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to