[
https://issues.apache.org/jira/browse/TS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067151#comment-15067151
]
ASF GitHub Bot commented on TS-4083:
------------------------------------
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/392
TS-4083: CID 1343347: Fix unchecked return value
@zwoop pls review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #392
----
commit 29877f7178c1138e3d03ded62e8c22a756c31f07
Author: Kit Chan <[email protected]>
Date: 2015-12-21T22:06:32Z
TS-4083: CID 1343347: Fix unchecked return value
----
> CID 1343347: Error handling issues in ts_lua_http.c
> ----------------------------------------------------
>
> Key: TS-4083
> URL: https://issues.apache.org/jira/browse/TS-4083
> Project: Traffic Server
> Issue Type: Bug
> Components: Lua, Plugins
> Reporter: Kit Chan
> Assignee: Kit Chan
> Fix For: 6.2.0
>
>
> {code}
> ** CID 1343347: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> ________________________________________________________________________________________________________
> *** CID 1343347: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> 331
> 332 GET_HTTP_CONTEXT(http_ctx, L);
> 333
> 334 url = luaL_checklstring(L, 1, &url_len);
> 335
> 336 if (url && url_len) {
> >>> CID 1343347: Error handling issues (CHECKED_RETURN)
> >>> Calling "TSCacheUrlSet" without checking return value (as is done
> >>> elsewhere 4 out of 5 times).
> 337 TSCacheUrlSet(http_ctx->txnp, url, url_len);
> 338 }
> 339
> 340 return 0;
> 341 }
> 342
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
