[
https://issues.apache.org/jira/browse/TS-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075660#comment-15075660
]
ASF GitHub Bot commented on TS-4095:
------------------------------------
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644987
--- Diff: plugins/experimental/webp_transform/metadata.h ---
@@ -0,0 +1,52 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+
+#ifndef METADATA_H_
+#define METADATA_H_
+
+#include "webp/types.h"
+
+#ifdef __cplusplus
+extern "C" {
--- End diff --
Why do these need to be ```extern "C"```? By doing that you're preventing
yourself from being able to use a constructor on MetadataPayload. I think
instead if your image library API requires C methods then you should use a void
pointer but keep your internal data class as C++ classes. Just a thought.
> New cppapi plugin for converting image formats to wepb
> ------------------------------------------------------
>
> Key: TS-4095
> URL: https://issues.apache.org/jira/browse/TS-4095
> Project: Traffic Server
> Issue Type: New Feature
> Components: CPP API, Plugins
> Reporter: Sandeep Davu
> Assignee: Brian Geffon
> Labels: review
> Fix For: 6.2.0
>
>
> Support for png and jpeg only. Webp is a format introduced by google and can
> retain the quality of the image by reducing the image size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
