[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097620#comment-15097620
]
ASF GitHub Bot commented on TS-4118:
------------------------------------
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/423
TS-4118: CID 1347871: Add error handling in HPACK_Encode
[TS-4118](https://issues.apache.org/jira/browse/TS-4118)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver TS-4118
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #423
----
commit 96b4d52015549e211d1b2ee9d5c773f18f408153
Author: Masaori Koshiba <[email protected]>
Date: 2016-01-12T01:07:56Z
TS-4118: CID 1347871: Add error handling in HPACK_Encode
----
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -------------------------------------------------------------
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
> CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
