[
https://issues.apache.org/jira/browse/TS-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149629#comment-15149629
]
Leif Hedstrom edited comment on TS-4201 at 2/17/16 1:10 AM:
------------------------------------------------------------
Interesting! Before we land this, how does one test this? What's the use case /
scenario where it crashes? Looking at the code, this seems like it could affect
clustering as well as SOCKS proxy?
was (Author: zwoop):
Interesting! Before we land this, how does one test this? What's the use case /
scenario where it crashes?
> OneWayTunnel::connection_closed callback handleEvent with wrong continuation
> ----------------------------------------------------------------------------
>
> Key: TS-4201
> URL: https://issues.apache.org/jira/browse/TS-4201
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Utilities
> Reporter: Oknet Xu
> Labels: review
>
> the OneWayTunnel::connection_closed code below:
> {code}
> void
> OneWayTunnel::connection_closed(int result)
> {
> if (cont) {
> #ifdef TEST
> cout << "OneWayTunnel::connection_closed() ... calling cont" << endl;
> #endif
> cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);
> } else {
> OneWayTunnel_free(this);
> }
> }
> {code}
> {code}cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);{code}
> It calls cont->handleEvent with `cont'.
> If `cont' is not NULL, the handleEvent will free this OneWayTunnel object.
> In order to free OneWayTunnel object, `cont' should be replaced by `this'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
