[ 
https://issues.apache.org/jira/browse/TS-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156316#comment-15156316
 ] 

ASF GitHub Bot commented on TS-4048:
------------------------------------

Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/490#issuecomment-186950232
  
    This looks generally reasonable.
    
    I'd like the patch series to be a bit cleaner; maybe fix the vagrant box 
URLs in the first commit, then switch over to the shell provisioner.
    
    We need to retain the additional build packages (``libcap-devel``, etc) so 
that optional components are always detected and built. It looks like you 
dropped FreeBSD, was that deliberate?


> Broken Vagrantfile in a lot of ways
> -----------------------------------
>
>                 Key: TS-4048
>                 URL: https://issues.apache.org/jira/browse/TS-4048
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Tools
>            Reporter: Christoph Keller
>            Priority: Minor
>             Fix For: sometime
>
>
> The Vagrant-File seems to be broken.
> 1. I tried to "vagrant up centos64" which failed due to files that could not 
> be downloaded during provisioning.
> 2. Saucy Images are no longer available and should be removed from 
> Vagrantfile.
> 3. I guess it would be better to use sshfs instead of nfs for the shared 
> folder due to the fact that a lot of people use encrypted home-directories 
> these days which makes mounting the shared folder fail. You don't even get a 
> proper errormessage for that.
> I didn't check all resources refered to by either Vagrantfile or the puppet 
> files but i guess there are even more broken links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to