Leif Hedstrom created TS-4231:
---------------------------------
Summary: Coverity issues in inlined plugin: CID 1352204 and CID
1352203
Key: TS-4231
URL: https://issues.apache.org/jira/browse/TS-4231
Project: Traffic Server
Issue Type: Bug
Components: Plugins
Reporter: Leif Hedstrom
{code}
** CID 1352204: Incorrect expression (USELESS_CALL)
________________________________________________________________________________________________________
*** CID 1352204: Incorrect expression (USELESS_CALL)
/plugins/experimental/inliner/ts.cc: 175 in
ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
169 case TS_EVENT_TIMEOUT:
170 TSError("[" PLUGIN_TAG "] TS_EVENT_TIMEOUT from producer");
171
172 handle_error:
173 operation.close();
174 assert(operation.action_ != NULL);
CID 1352204: Incorrect expression (USELESS_CALL)
Calling "TSActionDone(operation.action_)" is only useful for its return
value, which is ignored.
175 TSActionDone(operation.action_);
176 operation.action_ = NULL;
177 /*
178 TSContDataSet(c, NULL);
179 delete p;
180 */
** CID 1352203: Error handling issues (CHECKED_RETURN)
/plugins/experimental/inliner/ts.cc: 175 in
ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
________________________________________________________________________________________________________
*** CID 1352203: Error handling issues (CHECKED_RETURN)
/plugins/experimental/inliner/ts.cc: 175 in
ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
169 case TS_EVENT_TIMEOUT:
170 TSError("[" PLUGIN_TAG "] TS_EVENT_TIMEOUT from producer");
171
172 handle_error:
173 operation.close();
174 assert(operation.action_ != NULL);
CID 1352203: Error handling issues (CHECKED_RETURN)
Calling "TSActionDone" without checking return value (as is done elsewhere 8
out of 9 times).
175 TSActionDone(operation.action_);
176 operation.action_ = NULL;
177 /*
178 TSContDataSet(c, NULL);
179 delete p;
180 */
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
